enhancement: Move module navigation rendering to centralized, module-aware sidebar logic - #50
Open
glitched-matrix44 wants to merge 6 commits into
Open
enhancement: Move module navigation rendering to centralized, module-aware sidebar logic#50glitched-matrix44 wants to merge 6 commits into
glitched-matrix44 wants to merge 6 commits into
Conversation
…to IQU-enhancement-44
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const moduleTab = e.target.closest('.module-tab[data-href]'); | ||
| if (moduleTab) { | ||
| const href = moduleTab.dataset.href || moduleTab.getAttribute('href'); | ||
| if (href && href !== '#' && !href.startsWith('javascript:')) { |
| const dropdownItem = e.target.closest('.dropdown-item[data-menu][data-href]'); | ||
| if (dropdownItem) { | ||
| const href = dropdownItem.dataset.href || dropdownItem.getAttribute('href'); | ||
| if (href && href !== '#' && !href.startsWith('javascript:')) { |
| const primarySidebarUrl = getPrimarySidebarUrl(menu); | ||
| const targetHref = primarySidebarUrl || href; | ||
|
|
||
| if (!targetHref || targetHref === '#' || targetHref.startsWith('javascript:')) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the User Interface package to consume the new Foundation navigation model by replacing static module rendering with a centralized, navigation-driven workflow. Module tabs, sidebars, and shared layout components now render from Foundation navigation data while client-side rendering, active-state management, and navigation behavior are consolidated into a dedicated navigation renderer.
Key Changes
Rebuilt module-tabs.blade.php to render navigation from Foundation records instead of installed modules.
Added authentication and module-access filtering to ensure only authorized navigation items are displayed.
Introduced public/js/navigation/navigation-renderer.js to centralize sidebar rendering, active-state management, and navigation behavior.
Removed the legacy inline sidebar rendering logic from layouts/sidebar.blade.php.
Updated the header, minibar, mobile navigation, and module tab layouts to consume the shared navigation renderer.
Updated the UI controller and service provider to support the new navigation workflow.
Issue: #49