Pin python dependencies to avoid charmap sample PNGs evolving with new releases#103
Merged
Conversation
Member
Author
|
d261559 worked in the CI with sample regen. Going to try using an old lockfile to avoid a sample regen at all. |
Replace the unpinned pip3 install of scikit-image/scipy/matplotlib/parse
with a uv-compiled lockfile. The Dockerfile installs from the lockfile,
so layer-cache eviction can no longer silently pull newer matplotlib
versions and shift gen_charmap.py output.
The pinned versions match what the previously-cached fontbuilder image was
already running, so no sample regeneration is required and the font/sample
diff against master is empty.
Direct deps live in requirements.in; the lockfile is produced by:
uv pip compile xkcd-script/generator/requirements.in \
-o xkcd-script/generator/requirements.txt --python-version 3.12
To upgrade a dep, edit requirements.in (or pass --upgrade-package) and
re-run the compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.