Merged
Conversation
silvanocerza
deleted the
silvano/eng-532-fix-lite-api-country-data-parsing-in-erlang-library
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lite API country data wasn't parsed correctly and we were returning invalid values, like the country flag URL.
This PR fixes it.
I also had to slightly change a test in
ipinfo_SUITE.erlbecause now we correctly create an atom when parsing the Lite API response. Since tests are all compiled together that atom is also available toipinfo_SUITE.erltests and whenjsx:decodeis called withattempt_atomit converts the keys to atom instead of keeping it to binary.