feat: add currentDevice property to current device #15
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
======================================
Coverage 38.9% 38.9%
======================================
Files 54 54
Lines 1293 1293
Branches 163 163
======================================
Hits 503 503
Misses 681 681
Partials 109 109
Continue to review full report at Codecov.
|
paulobmarcos
force-pushed
the
feat_current-device-prop
branch
from
e5ca584 to
c965a16
Compare
paulobmarcos
force-pushed
the
feat_current-device-prop
branch
from
c965a16 to
61954c7
Compare
1 task
satazor
suggested changes
Jul 5, 2019
| @@ -111,7 +111,7 @@ class Devices { | |||
|
|
|||
| if (this.#devicesMap[currentId]) { | |||
| this.#devicesMap[currentId] = merge( | |||
| { ...this.#devicesMap[currentId] }, | |||
| { ...this.#devicesMap[currentId], current: true }, | |||
There was a problem hiding this comment.
Should we add current: false to others?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue: ipfs-shipyard/pm-idm#197