-
Notifications
You must be signed in to change notification settings - Fork 74
add guide to creating your own ipfs transport #58
base: master
Are you sure you want to change the base?
Conversation
@whyrusleeping I know spell checkers are annoying due to not knowing all of the terminology, but I think adding apostrophes in contractions, and capitalizing 'I' is something that needs to be done, and I don't think it's the reviewer's job to point out things like that. Can you do a pass with your spell checker before asking for feedback? This is basically the same as asking me to do |
@@ -0,0 +1,199 @@ | |||
# Implementing a new libp2p transport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be great to have one in js
as well ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course :)
I believe it would help to understand if the blog post was divided into two sections: a) how to plug in the WebSockets transport into libp2p (just reusing the module that is already there and making a dial); b) how to design a transport for libp2p, taking into example how the WebSockets was built |
Is this good to go? |
No. It needs to be copy edited. I asked @whyrusleeping to go over it again. @whyrusleeping can you help with that? I can split it into two parts after that. |
cc @diasdavid @lgierth @RichardLitt for review and feedback