Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: move partitions #8

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
924722e
init
zhiqiangxu Jun 25, 2023
da95dbb
avoid recompute current_deadline
zhiqiangxu Jun 25, 2023
e502709
treat empty bitfield as all
zhiqiangxu Jun 26, 2023
eaf5370
rm useless quote
zhiqiangxu Jun 26, 2023
2fa9693
add verify
zhiqiangxu Jun 27, 2023
8725420
combine option1 & option2
zhiqiangxu Jun 28, 2023
d534373
fix
zhiqiangxu Jun 28, 2023
36caece
fix
zhiqiangxu Jun 28, 2023
badb691
nit
zhiqiangxu Jun 28, 2023
fd39aac
mod error
zhiqiangxu Jun 28, 2023
daab781
nit
zhiqiangxu Jun 28, 2023
0271369
fmt
zhiqiangxu Jun 28, 2023
c046cc6
fix ci
zhiqiangxu Jun 28, 2023
3eac91e
fix bug
zhiqiangxu Jul 3, 2023
181dc2e
add test
zhiqiangxu Jul 4, 2023
8eb2243
add more test
zhiqiangxu Jul 5, 2023
394ea44
Merge remote-tracking branch 'origin/master' into feature/move_partit…
zhiqiangxu Jul 11, 2023
d1fdb0f
partial fix for review
zhiqiangxu Jul 18, 2023
0804565
Merge remote-tracking branch 'origin/master' into feature/move_partit…
zhiqiangxu Jul 19, 2023
0353a28
adjust test
zhiqiangxu Jul 19, 2023
bc9e6a1
use .context_code
zhiqiangxu Jul 19, 2023
c1d88a2
fix for test
zhiqiangxu Jul 19, 2023
37d7d03
disallow empty partitions
zhiqiangxu Jul 19, 2023
89bcb74
refactor deadline_available_for_move
zhiqiangxu Jul 19, 2023
79ab15d
fix for clippy
zhiqiangxu Jul 19, 2023
39d6447
minor opt
zhiqiangxu Jul 19, 2023
0bd0611
only verify_windowed_post once
zhiqiangxu Jul 20, 2023
c01b54c
mod error msg
zhiqiangxu Jul 24, 2023
ccdb45f
1. verify_window_post batch by batch
zhiqiangxu Jul 25, 2023
b775fa8
fix ci
zhiqiangxu Jul 25, 2023
a5290cc
mod check for epoch
zhiqiangxu Jul 25, 2023
bf13558
partial review fix
zhiqiangxu Aug 2, 2023
9195aa1
Merge remote-tracking branch 'origin/master' into feature/move_partit…
zhiqiangxu Aug 2, 2023
70fd5fe
adjust test
zhiqiangxu Aug 2, 2023
511e170
refactor with Partition::adjust_for_move
zhiqiangxu Aug 2, 2023
d16077c
share the language with FIP
zhiqiangxu Aug 30, 2023
9ed53b8
deadline_available_for_move => ensure_deadline_available_for_move
zhiqiangxu Aug 30, 2023
15d5ac1
add some doc comment
zhiqiangxu Aug 30, 2023
5744223
more renaming
zhiqiangxu Aug 30, 2023
e8f0a22
more renaming
zhiqiangxu Aug 30, 2023
194b7cd
Merge remote-tracking branch 'origin/master' into feature/move_partit…
zhiqiangxu Aug 30, 2023
5e400d2
rename + merge master
zhiqiangxu Aug 30, 2023
c1159c5
mod wording
zhiqiangxu Aug 30, 2023
cb5e3c4
fix test
zhiqiangxu Aug 30, 2023
faa4873
renaming in test
zhiqiangxu Aug 31, 2023
7bc1156
apply alex's idea of not re-quantizing at all.
zhiqiangxu Sep 19, 2023
f7b7bd7
1. forbid moving when there're early terminations
zhiqiangxu Sep 22, 2023
3b25fdc
rm anyhow::Ok
zhiqiangxu Sep 22, 2023
f3ddb23
Merge branch 'master' into feature/move_partition_verify
zhiqiangxu Sep 23, 2023
9c8517a
minor optimization by observing that partition `faulty_power` should …
zhiqiangxu Sep 23, 2023
3c6a374
adjust find_sectors_by_expiration for not re-quantizing
zhiqiangxu Sep 25, 2023
271e3c0
add test
zhiqiangxu Sep 26, 2023
d2202ab
fix for review
zhiqiangxu Sep 26, 2023
d276241
add a comment about not re-quantizing when moving expirations_epochs
zhiqiangxu Sep 26, 2023
b2dc66c
minor optimization
zhiqiangxu Sep 27, 2023
fcc4cc0
avoid scanning the same range twice
zhiqiangxu Sep 28, 2023
7619065
1. review fix
zhiqiangxu Sep 28, 2023
6e91261
fix comment
zhiqiangxu Sep 28, 2023
9964257
use with_context_code
zhiqiangxu Sep 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
share the language with FIP
zhiqiangxu committed Aug 30, 2023
commit d16077cfb5a0522c4e06c54c285365570525f0ce
20 changes: 10 additions & 10 deletions actors/miner/src/deadlines.rs
Original file line number Diff line number Diff line change
@@ -140,40 +140,40 @@ fn deadline_distance(policy: &Policy, from_deadline: u64, to_deadline: u64) -> u
// only allow moving to a nearer deadline from current one
pub fn deadline_available_for_move(
policy: &Policy,
from_deadline: u64,
to_deadline: u64,
orig_deadline: u64,
dest_deadline: u64,
current_deadline: &DeadlineInfo,
) -> Result<(), String> {
if !deadline_is_mutable(
policy,
current_deadline.period_start,
from_deadline,
orig_deadline,
current_deadline.current_epoch,
) {
return Err(format!(
"cannot move from a deadline {}, immutable at epoch {}",
from_deadline, current_deadline.current_epoch
orig_deadline, current_deadline.current_epoch
));
}

if !deadline_is_mutable(
policy,
current_deadline.period_start,
to_deadline,
dest_deadline,
current_deadline.current_epoch,
) {
return Err(format!(
"cannot move to a deadline {}, immutable at epoch {}",
to_deadline, current_deadline.current_epoch
dest_deadline, current_deadline.current_epoch
));
}

if deadline_distance(policy, current_deadline.index, to_deadline)
>= deadline_distance(policy, current_deadline.index, from_deadline)
if deadline_distance(policy, current_deadline.index, dest_deadline)
>= deadline_distance(policy, current_deadline.index, orig_deadline)
{
return Err(format!(
"can only move to a deadline which is nearer from current deadline {}, to_deadline {} is not nearer than from_deadline {}",
current_deadline.index, to_deadline, from_deadline
"can only move to a deadline which is nearer from current deadline {}, dest_deadline {} is not nearer than orig_deadline {}",
current_deadline.index, dest_deadline, orig_deadline
));
}

58 changes: 29 additions & 29 deletions actors/miner/src/lib.rs
Original file line number Diff line number Diff line change
@@ -2993,18 +2993,18 @@ impl Actor {
}

fn move_partitions(rt: &impl Runtime, params: MovePartitionsParams) -> Result<(), ActorError> {
if params.from_deadline == params.to_deadline {
return Err(actor_error!(illegal_argument, "from_deadline == to_deadline"));
if params.orig_deadline == params.dest_deadline {
return Err(actor_error!(illegal_argument, "orig_deadline == dest_deadline"));
}
let policy = rt.policy();
if params.from_deadline >= policy.wpost_period_deadlines
|| params.to_deadline >= policy.wpost_period_deadlines
if params.orig_deadline >= policy.wpost_period_deadlines
|| params.dest_deadline >= policy.wpost_period_deadlines
{
return Err(actor_error!(
illegal_argument,
"invalid param, from_deadline: {}, to_deadline: {}",
params.from_deadline,
params.to_deadline
"invalid param, orig_deadline: {}, dest_deadline: {}",
params.orig_deadline,
params.dest_deadline
));
}
if params.partitions.is_empty() {
@@ -3026,19 +3026,19 @@ impl Actor {

deadline_available_for_move(
policy,
params.from_deadline,
params.to_deadline,
params.orig_deadline,
params.dest_deadline,
&current_deadline,
)
.context_code(
ExitCode::USR_FORBIDDEN,
"conditions not satisfied for deadline_available_for_move",
)?;

let mut from_deadline =
deadlines.load_deadline(policy, store, params.from_deadline).context_code(
let mut orig_deadline =
deadlines.load_deadline(policy, store, params.orig_deadline).context_code(
ExitCode::USR_ILLEGAL_STATE,
format!("failed to load deadline {}", params.from_deadline),
format!("failed to load deadline {}", params.orig_deadline),
)?;
// only try to do synchronous Window Post verification if the from deadline is in dispute window
// note that as window post is batched, the best we can do is to verify only those that contains at least one partition being moved.
@@ -3047,25 +3047,25 @@ impl Actor {
if deadline_available_for_optimistic_post_dispute(
policy,
current_deadline.period_start,
params.from_deadline,
params.orig_deadline,
rt.curr_epoch(),
) {
let proofs_snapshot = from_deadline
let proofs_snapshot = orig_deadline
.optimistic_proofs_snapshot_amt(store)
.context_code(ExitCode::USR_ILLEGAL_STATE, "failed to load proofs snapshot")?;

let partitions_snapshot =
from_deadline.partitions_snapshot_amt(store).context_code(
orig_deadline.partitions_snapshot_amt(store).context_code(
ExitCode::USR_ILLEGAL_STATE,
"failed to load partitions snapshot",
)?;

// Find the proving period start for the deadline in question.
let target_deadline =
nearest_occured_deadline_info(policy, &current_deadline, params.from_deadline);
nearest_occured_deadline_info(policy, &current_deadline, params.orig_deadline);

// Load sectors for the dispute.
let sectors = Sectors::load(rt.store(), &from_deadline.sectors_snapshot)
let sectors = Sectors::load(rt.store(), &orig_deadline.sectors_snapshot)
.context_code(ExitCode::USR_ILLEGAL_STATE, "failed to load sectors array")?;

proofs_snapshot
@@ -3140,41 +3140,41 @@ impl Actor {
.context_code(ExitCode::USR_ILLEGAL_STATE, "while removing partitions")?;
}

let to_quant = state.quant_spec_for_deadline(policy, params.to_deadline);
let dest_quant = state.quant_spec_for_deadline(policy, params.dest_deadline);

let mut to_deadline =
deadlines.load_deadline(policy, store, params.to_deadline).context_code(
let mut dest_deadline =
deadlines.load_deadline(policy, store, params.dest_deadline).context_code(
ExitCode::USR_ILLEGAL_STATE,
format!("failed to load deadline {}", params.to_deadline),
format!("failed to load deadline {}", params.dest_deadline),
)?;

Deadlines::move_partitions(
store,
&mut from_deadline,
&mut to_deadline,
to_quant,
&mut orig_deadline,
&mut dest_deadline,
dest_quant,
&params.partitions,
)
.context_code(ExitCode::USR_ILLEGAL_STATE, "failed to move partitions")?;

deadlines
.update_deadline(policy, store, params.from_deadline, &from_deadline)
.update_deadline(policy, store, params.orig_deadline, &orig_deadline)
.context_code(
ExitCode::USR_ILLEGAL_STATE,
format!("failed to update deadline {}", params.from_deadline),
format!("failed to update deadline {}", params.orig_deadline),
)?;
deadlines
.update_deadline(policy, store, params.to_deadline, &to_deadline)
.update_deadline(policy, store, params.dest_deadline, &dest_deadline)
.context_code(
ExitCode::USR_ILLEGAL_STATE,
format!("failed to update deadline {}", params.to_deadline),
format!("failed to update deadline {}", params.dest_deadline),
)?;

state.save_deadlines(store, deadlines).context_code(
ExitCode::USR_ILLEGAL_STATE,
format!(
"failed to save deadline when move_partitions from {} to {}",
params.from_deadline, params.to_deadline
params.orig_deadline, params.dest_deadline
),
)?;

4 changes: 2 additions & 2 deletions actors/miner/src/types.rs
Original file line number Diff line number Diff line change
@@ -245,8 +245,8 @@ pub struct CompactPartitionsParams {

#[derive(Serialize_tuple, Deserialize_tuple)]
pub struct MovePartitionsParams {
pub from_deadline: u64,
pub to_deadline: u64,
pub orig_deadline: u64,
pub dest_deadline: u64,
pub partitions: BitField,
}

6 changes: 3 additions & 3 deletions actors/miner/tests/util.rs
Original file line number Diff line number Diff line change
@@ -2602,14 +2602,14 @@ impl ActorHarness {
pub fn move_partitions(
&self,
rt: &MockRuntime,
from_deadline: u64,
to_deadline: u64,
orig_deadline: u64,
dest_deadline: u64,
partitions: BitField,
mut f: impl FnMut(),
) -> Result<(), ActorError> {
f();

let params = MovePartitionsParams { from_deadline, to_deadline, partitions };
let params = MovePartitionsParams { orig_deadline, dest_deadline, partitions };

rt.expect_validate_caller_addr(self.caller_addrs());
rt.set_caller(*ACCOUNT_ACTOR_CODE_ID, self.worker);
4 changes: 2 additions & 2 deletions test_vm/tests/move_partitions_test.rs
Original file line number Diff line number Diff line change
@@ -40,8 +40,8 @@ fn move_partitions_success() {
advance_by_deadline_to_epoch(&v, &miner.miner_id, prove_time);

let move_params = MovePartitionsParams {
from_deadline: 0,
to_deadline: 47,
orig_deadline: 0,
dest_deadline: 47,
partitions: make_bitfield(&[0u64]),
};
let prove_params_ser = IpldBlock::serialize_cbor(&move_params).unwrap();