fix: docker pull

ipdxco · Mar 10, 2023 · 747cd0a · 747cd0a
1 parent 2296897
commit 747cd0a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [1.1.4] - 2023-03-10
+### Fixed
+- Correctly validate if docker pull was successful
+
 ## [1.1.3] - 2023-03-10
 ### Added
 - Added `.github/actions/github` composite action to infer GitHub action repository and ref from GitHub action path

diff --git a/action.yml b/action.yml
@@ -50,9 +50,9 @@ runs:
         IMAGE: ${{ inputs.image || inputs.repository }}
         TAG: ${{ inputs.tag || inputs.ref }}
         DOCKER_REGISTRY_URL: ${{ inputs.docker-registry-url }}
-      run: echo "exit=$(docker pull ${DOCKER_REGISTRY_URL#http*://}/$IMAGE:$TAG; echo $?)" >> $GITHUB_OUTPUT
+      run: echo "image=$(docker pull ${DOCKER_REGISTRY_URL#http*://}/$IMAGE:$TAG -q || true)" >> $GITHUB_OUTPUT
       shell: bash
-    - if: steps.pull.outputs.exit == 1
+    - if: steps.pull.outputs.image == ''
       env:
         REPOSITORY: ${{ inputs.repository }}
         REF: ${{ inputs.ref }}