Fix template path, use poetry to manage dependencies #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipa-rwu
force-pushed
the
rwu/fix/template_path
branch
5 times, most recently
from
d7faf8b to
f6890bd
Compare
ipa-rwu
force-pushed
the
rwu/fix/template_path
branch
from
f6890bd to
d0f0718
Compare
ipa-rwu
commented
Feb 27, 2024
| @@ -37,7 +37,7 @@ def __init__(self, template_path=None) -> None: | |||
| if template_path != None: | |||
| self.template_path = Path(template_path).resolve() | |||
| elif Template_ROS != None and Template_ROS.is_file(): | |||
| self.template_path = Template | |||
| self.template_path = Template_ROS | |||
There was a problem hiding this comment.
It should be Template_ROS if build with ROS
| @@ -36,7 +36,7 @@ def __init__(self, template_path=None) -> None: | |||
| if template_path != None: | |||
| self.template_path = Path(template_path).resolve() | |||
| elif Template_ROS != None and Template_ROS.is_file(): | |||
| self.template_path = Template | |||
| self.template_path = Template_ROS | |||
There was a problem hiding this comment.
It should be Template_ROS if build with ROS
|
@ipa-rwu Cool! Many thanks, I just tested it, and works! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ipa-nhg It should be
Template_ROSif build with ROS. I also update README to build ROS properly