Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 3d mapping msgs #60

Merged
merged 78 commits into from
Mar 16, 2016
Merged

Conversation

fmessmer
Copy link
Member

@ipa-rmb FYI
let's merge once everything is settled:

I'll keep you updated!

@fmessmer
Copy link
Member Author

@ipa-rmb
Quick question: I don't like to much that cob_perception_common now depends on cob_object_perception (because cob_3d_mapping_msgs depends on cob_object_detection_msgs). Should we also move cob_object_detection_msgs into cob_perception_common to have all message definitions here in cob_perception_common?

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Mar 16, 2016

It is already there :-)

@fmessmer
Copy link
Member Author

ups, my bad!

Can you then please give the combo

a quick test whether it works as expected?
It should not have any effect on cob_object_perception...

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Mar 16, 2016

It compiles on my machine. I do not have a quick test but it looks good. We can merge it.

@fmessmer
Copy link
Member Author

compiles on my machine and travis is happy, too....feel free to merge the two PRs...I'll then continue to fix cob_scenario_states

ipa-rmb added a commit that referenced this pull request Mar 16, 2016
@ipa-rmb ipa-rmb merged commit 550d830 into ipa320:indigo_dev Mar 16, 2016
@fmessmer fmessmer deleted the move_3d_mapping_msgs branch March 17, 2016 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants