Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi distro travis #46

Merged
merged 6 commits into from
Mar 20, 2017
Merged

Conversation

fmessmer
Copy link
Member

@fmessmer fmessmer commented Mar 17, 2017

@fmessmer fmessmer force-pushed the multi_distro_travis branch 4 times, most recently from 278e996 to 71a9479 Compare March 18, 2017 16:19
@fmessmer
Copy link
Member Author

Hmm, I don't like 71a9479 and also it does not fix:

Errors     << cob_marker:make /root/catkin_ws/logs/cob_marker/build.make.000.log

In file included from /root/catkin_ws/src/cob_object_perception/cob_marker/common/include/cob_marker/zxing/MagickBitmapSource.h:5:0,

                 from /root/catkin_ws/src/cob_object_perception/cob_marker/common/src/MagickBitmapSource.cpp:17:

/root/catkin_ws/devel/include/libzxing/LuminanceSource.h:23:34: fatal error: zxing/common/Counted.h: No such file or directory

 #include <zxing/common/Counted.h>

                                  ^

compilation terminated.

make[2]: *** [CMakeFiles/marker.dir/common/src/MagickBitmapSource.cpp.o] Error 1

make[2]: *** Waiting for unfinished jobs....

In file included from /root/catkin_ws/src/cob_object_perception/cob_marker/common/include/cob_marker/zxing/MagickBitmapSource.h:5:0,

                 from /root/catkin_ws/src/cob_object_perception/cob_marker/common/include/cob_marker/zxing/pc2magick.h:73,

                 from /root/catkin_ws/src/cob_object_perception/cob_marker/common/include/cob_marker/general_marker.h:82,

                 from /root/catkin_ws/src/cob_object_perception/cob_marker/ros/src/marker_action.cpp:78:

/root/catkin_ws/devel/include/libzxing/LuminanceSource.h:23:34: fatal error: zxing/common/Counted.h: No such file or directory

 #include <zxing/common/Counted.h>

                                  ^

compilation terminated.

make[2]: *** [CMakeFiles/marker.dir/ros/src/marker_action.cpp.o] Error 1

make[1]: *** [CMakeFiles/marker.dir/all] Error 2

make: *** [all] Error 2

The problem is that all the headers are referring to the headers as <zxing/*> which is in contrary to the package name libzxing...
I guess renaming the package would be an option....
@ipa-mdl do you know a better solution?

@mathias-luedtke
Copy link

What's the output if you just omit 71a9479?

@fmessmer
Copy link
Member Author

well without, I get the same error but from within header files in cob_marker and cob_texture_categorization....

@mathias-luedtke
Copy link

cob_marker and cob_texture_categorization should not contain the 3rd party headers..

@fmessmer fmessmer force-pushed the multi_distro_travis branch 2 times, most recently from d7bf2c0 to 67c81c7 Compare March 19, 2017 12:08
@fmessmer fmessmer force-pushed the multi_distro_travis branch from 67c81c7 to 5ce8e55 Compare March 19, 2017 12:16
@fmessmer fmessmer force-pushed the multi_distro_travis branch from 5ce8e55 to 8832f70 Compare March 19, 2017 12:30
@fmessmer
Copy link
Member Author

Solved it by copying and installing the headers into zxing folder (instead of libzxing) and adjusting the CFG_EXTRAS accordingly...This way, I do not need to touch any depending package...

@fmessmer fmessmer mentioned this pull request Mar 20, 2017
@fmessmer
Copy link
Member Author

this repo needs a specific kinetic_dev branch that fixes e.g. the issues with cv, Eigen3,...
tracking this in a separate issue #47

@fmessmer fmessmer merged commit 33d8609 into ipa320:indigo_dev Mar 20, 2017
@fmessmer fmessmer deleted the multi_distro_travis branch March 20, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants