Skip to content

Forked ChainManager #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions blockchain/blockchain.go
Original file line number Diff line number Diff line change
Expand Up @@ -454,10 +454,7 @@ func (bc *blockchain) MintNewBlock(timestamp time.Time, opts ...MintOption) (*bl
ctx = bc.contextWithBlock(ctx, minterAddress, newblockHeight, timestamp, protocol.CalcBaseFee(genesis.MustExtractGenesisContext(ctx).Blockchain, &tip), protocol.CalcExcessBlobGas(tip.ExcessBlobGas, tip.BlobGasUsed))
ctx = protocol.WithFeatureCtx(ctx)
// run execution and update state trie root hash
blk, err := bc.bbf.Mint(
ctx,
producerPrivateKey,
)
blk, err := bc.bbf.Mint(ctx, producerPrivateKey)
if err != nil {
return nil, errors.Wrapf(err, "failed to create block")
}
Expand Down
5 changes: 3 additions & 2 deletions chainservice/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,8 @@ func (builder *Builder) createBlockchain(forSubChain, forTest bool) blockchain.B
if builder.cfg.Consensus.Scheme == config.RollDPoSScheme {
mintOpts = append(mintOpts, factory.WithTimeoutOption(builder.cfg.Chain.MintTimeout))
}
minter := factory.NewMinter(builder.cs.factory, builder.cs.actpool, mintOpts...)
return blockchain.NewBlockchain(builder.cfg.Chain, builder.cfg.Genesis, builder.cs.blockdao, minter, chainOpts...)
builder.cs.minter = factory.NewMinter(builder.cs.factory, builder.cs.actpool, mintOpts...)
return blockchain.NewBlockchain(builder.cfg.Chain, builder.cfg.Genesis, builder.cs.blockdao, builder.cs.minter, chainOpts...)
}

func (builder *Builder) buildNodeInfoManager() error {
Expand Down Expand Up @@ -786,6 +786,7 @@ func (builder *Builder) buildConsensusComponent() error {
}
if rDPoSProtocol := rolldpos.FindProtocol(builder.cs.registry); rDPoSProtocol != nil {
copts = append(copts, consensus.WithRollDPoSProtocol(rDPoSProtocol))
copts = append(copts, consensus.WithBlockBuilderFactory(builder.cs.minter))
}
if pollProtocol := poll.FindProtocol(builder.cs.registry); pollProtocol != nil {
copts = append(copts, consensus.WithPollProtocol(pollProtocol))
Expand Down
1 change: 1 addition & 0 deletions chainservice/chainservice.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ type ChainService struct {
nodeInfoManager *nodeinfo.InfoManager
apiStats *nodestats.APILocalStats
actionsync *actsync.ActionSync
minter *factory.Minter
}

// Start starts the server
Expand Down
36 changes: 28 additions & 8 deletions consensus/consensus.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"context"

"github.com/facebookgo/clock"
"github.com/iotexproject/go-pkgs/hash"
"github.com/iotexproject/iotex-proto/golang/iotextypes"
"github.com/pkg/errors"
"go.uber.org/zap"
Expand All @@ -24,7 +25,6 @@ import (
"github.com/iotexproject/iotex-core/v2/pkg/lifecycle"
"github.com/iotexproject/iotex-core/v2/pkg/log"
"github.com/iotexproject/iotex-core/v2/state"
"github.com/iotexproject/iotex-core/v2/state/factory"
)

// Consensus is the interface for handling IotxConsensus view change.
Expand All @@ -49,6 +49,7 @@ type optionParams struct {
broadcastHandler scheme.Broadcast
pp poll.Protocol
rp *rp.Protocol
bbf rolldpos.BlockBuilderFactory
}

// Option sets Consensus construction parameter.
Expand Down Expand Up @@ -78,11 +79,19 @@ func WithPollProtocol(pp poll.Protocol) Option {
}
}

// WithBlockBuilderFactory is an option to set block builder factory
func WithBlockBuilderFactory(bbf rolldpos.BlockBuilderFactory) Option {
return func(ops *optionParams) error {
ops.bbf = bbf
return nil
}
}

// NewConsensus creates a IotxConsensus struct.
func NewConsensus(
cfg rolldpos.BuilderConfig,
bc blockchain.Blockchain,
sf factory.Factory,
sf rolldpos.StateReaderFactory,
opts ...Option,
) (Consensus, error) {
var ops optionParams
Expand All @@ -100,7 +109,19 @@ func NewConsensus(
var err error
switch cfg.Scheme {
case RollDPoSScheme:
delegatesByEpochFunc := func(epochNum uint64) ([]string, error) {
if ops.bbf == nil {
return nil, errors.New("block builder factory is not set")
}
chainMgr := rolldpos.NewChainManager(bc, sf, ops.bbf)
delegatesByEpochFunc := func(epochNum uint64, prevHash []byte) ([]string, error) {
fork, err := chainMgr.Fork(hash.Hash256(prevHash))
if err != nil {
return nil, err
}
forkSF, err := fork.StateReader()
if err != nil {
return nil, err
}
re := protocol.NewRegistry()
if err := ops.rp.Register(re); err != nil {
return nil, err
Expand All @@ -110,15 +131,14 @@ func NewConsensus(
cfg.Genesis,
)
ctx = protocol.WithFeatureWithHeightCtx(ctx)
tipHeight := bc.TipHeight()
tipHeight := fork.TipHeight()
tipEpochNum := ops.rp.GetEpochNum(tipHeight)
var candidatesList state.CandidateList
var err error
switch epochNum {
case tipEpochNum:
candidatesList, err = ops.pp.Delegates(ctx, sf)
candidatesList, err = ops.pp.Delegates(ctx, forkSF)
case tipEpochNum + 1:
candidatesList, err = ops.pp.NextDelegates(ctx, sf)
candidatesList, err = ops.pp.NextDelegates(ctx, forkSF)
default:
err = errors.Errorf("invalid epoch number %d compared to tip epoch number %d", epochNum, tipEpochNum)
}
Expand All @@ -135,7 +155,7 @@ func NewConsensus(
bd := rolldpos.NewRollDPoSBuilder().
SetPriKey(cfg.Chain.ProducerPrivateKeys()...).
SetConfig(cfg).
SetChainManager(rolldpos.NewChainManager(bc)).
SetChainManager(chainMgr).
SetBlockDeserializer(block.NewDeserializer(bc.EvmNetworkID())).
SetClock(clock).
SetBroadcast(ops.broadcastHandler).
Expand Down
Loading