Prepare next proposal #4586
Closed
Prepare next proposal #4586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
|
envestcc
commented
Mar 21, 2025
| @@ -378,6 +378,10 @@ func (sdb *stateDB) ReadView(name string) (interface{}, error) { | |||
| return sdb.protocolView.Read(name) | |||
| } | |||
|
|
|||
| func (sdb *stateDB) StateReaderAt(header *block.Header) (protocol.StateReader, error) { | |||
| panic("implement me") | |||
There was a problem hiding this comment.
will implement after #4581
CoderZhi
reviewed
Mar 23, 2025
Comment on lines
+413
to
+417
| func WithConsensusRoundCtx(ctx context.Context, round ConsensusRoundCtx) context.Context { | ||
| return context.WithValue(ctx, consensusRoundContextKey{}, round) | ||
| } | ||
|
|
||
| func MustGetConsensusRoundCtx(ctx context.Context) ConsensusRoundCtx { |
There was a problem hiding this comment.
if necessary, move to package rolldpos
| } | ||
|
|
||
| // MintNewBlock creates a new block with given actions | ||
| func (fc *forkChain) MintNewBlock(ctx context.Context) (*block.Block, error) { |
There was a problem hiding this comment.
add parameters:
StartTime time.Time
EncodedProposer string
PrevHash hash.Hash256
Round is not in use, Height is always equal to tipHeight + 1
Comment on lines
+111
to
+115
| Mint(ctx context.Context) (*block.Block, error) | ||
| ReceiveBlock(*block.Block) error | ||
| Init(hash.Hash256) | ||
| AddProposal(*block.Block) error | ||
| Block(hash.Hash256) *block.Block |
There was a problem hiding this comment.
the BlockBuilderFactory defined here doesn't need to contain all the functions.
| @@ -513,12 +513,16 @@ func (builder *Builder) createBlockchain(forSubChain, forTest bool) blockchain.B | |||
| } else { | |||
| chainOpts = append(chainOpts, blockchain.BlockValidatorOption(builder.cs.factory)) | |||
| } | |||
| consensusCfg := consensusfsm.NewConsensusConfig(builder.cfg.Consensus.RollDPoS.FSM, builder.cfg.DardanellesUpgrade, builder.cfg.Genesis, builder.cfg.Consensus.RollDPoS.Delay) | |||
There was a problem hiding this comment.
single node mode may have problem. so, we need to rethink about the usage of BlockTimeCalculatorBuilder.
|
|
||
| var mintOpts []factory.MintOption | ||
| mintOpts := []factory.MintOption{factory.WithPrivateKeyOption(builder.cfg.Chain.ProducerPrivateKey())} |
There was a problem hiding this comment.
moving private key to consensus may be a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
two major changes introduced:
base #4582
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: