update for fsac single console #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Krzysztof-Cieslak I'll merge ionide/FsAutoComplete#212 soon to |
|
ok, is merged in FSAC, so i updated the paket dep here. ready to review @Krzysztof-Cieslak |
Krzysztof-Cieslak
added a commit
that referenced
this pull request
Sep 22, 2017
This reverts commit 8a9fae2.
Krzysztof-Cieslak
added a commit
that referenced
this pull request
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ionide/FsAutoComplete#212
now fsac has one single console app
fsautocomplete.exeto enable old suave mode:
--mode http --port <PORT>This pr also add the usage of
--hostPIDargumentref ionide/FsAutoComplete#190
this enable FSAC to track vscode process, and quit when that process is
terminated (so will avoid zombies if vscode is not terminated gracefully)