Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat more exception types as non-fatal #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Treat more exception types as non-fatal #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/LanguageServerProtocol.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@ module Server =
open Ionide.LanguageServerProtocol.JsonUtils
open Newtonsoft.Json.Linq

let rec (|HandleableException|_|) (e: exn) =
match e with
| :? LocalRpcException -> Some ()
| :? TaskCanceledException -> Some ()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this change doesn't clash with the revamp branch, I also recommend catching OperationCanceledException

| :? System.AggregateException as aex ->
if aex.InnerExceptions.Count = 1 then
(|HandleableException|_|) aex.InnerException
else
None
| _ -> None

let logger = LogProvider.getLoggerByName "LSP Server"

let jsonRpcFormatter = new JsonMessageFormatter()
Expand Down Expand Up @@ -92,7 +103,7 @@ module Server =
{ new JsonRpc(jsonRpcHandler) with
member this.IsFatalException(ex: Exception) =
match ex with
| :? LocalRpcException -> false
| HandleableException -> false
| _ -> true
}

Expand Down