This repository was archived by the owner on May 4, 2022. It is now read-only.
Fix nav bar title computed width #215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Fix the computed nav bar title width.
Changes proposed in this pull request:
Previously for the width, the first element with the
nav-bar-titleclass was used, but it can be the one hidden (cached) from the previous screen, used for animations, so the change was to check that we do not use the hidden one.By the way, I also fixed spacing issue in
refresher.jsto allow starting the validation. The 17 broken unit tests were already broken before my fix (on OSX).Ionic Version: 1.x
Fixes: #38 , ionic-team/ionic-framework#4661