Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #24587
What is the current behavior?
Currently, the
ActivatedRoutethation-router-outletinjects into a page copiessnapshotonce, when the page is activated. A navigation that only changes query params reuses the page without re-activating the outlet, soroute.snapshotstays stale (e.g.,snapshot.queryParamMap.get('foo')isnullafter navigating to?foo=bar).What is the new behavior?
The proxy's
snapshotnow reads from the route it stands in for, so it always matches the current URL.Does this introduce a breaking change?
Other information
The issue's broken relative links stopped reproducing once Angular started building URL trees from the snapshot itself (all supported versions do). The stale snapshot behind it was still there. The new spec also covers relative links so the original symptom stays fixed, but reverting this fix will not break that test because it's just to make sure this issue doesn't come up again even though it's technically not a problem right now.