Repository navigation
feat(split-pane): resolve breakpoints from config - #31521
Open
brandyscarney wants to merge 2 commits into
Open
brandyscarney wants to merge 2 commits into
brandyscarney wants to merge 2 commits into
Conversation
brandyscarney
added this pull request to stack #31503
October 1, 2026 22:43
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
force-pushed
the
FW-7285-5-split-pane
branch
from
October 1, 2026 23:06
f46b836 to
5ac1932
Compare
brandyscarney
marked this pull request as ready for review
October 2, 2026 13:50
ShaneK
approved these changes
Oct 5, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looks good to me, great work! Just a couple of optional nits in the tests.
brandyscarney
force-pushed
the
FW-7285-5-split-pane
branch
from
October 6, 2026 19:46
5ac1932 to
788310a
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
whenproperty accepts a CSS media query, a boolean, or one of the shortcut expressions"xs"through"xl"and"never". The shortcuts map to fixed widths that cannot be changed. The default value is'(min-width: 992px)'.What is the new behavior?
screenBreakpointsconfig also changes the width at which the split pane appears."xxl"is now a supported shortcut."lg"shortcut. It resolves to the same992pxunlesslgis configured otherwise."never"behave exactly as before.Does this introduce a breaking change?
The default value of
whenchanged from'(min-width: 992px)'to'lg'. The default behavior is unchanged, but code that reads or compareswhenagainst the old literal needs updating.Other information
Preview