feat(header, footer, tab-bar): add scrollEffect prop#31263
Conversation
…rrect theme class usage
…orce footer priority
…llEffect in all modes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
left a comment
There was a problem hiding this comment.
Hey, great work on this! I highlighted a few issues I found, some of them aren't as important as others, but still
2a64a10 to
7756065
Compare
@ShaneK Thanks for all the help on this! I addressed your latest round of comments and also noticed that some tests were using the deprecated |
ShaneK
left a comment
There was a problem hiding this comment.
Thanks for those changes, we're looking amazing! Just a few remaining things I noticed and I think we're done after this!
016e0d6 to
eba6da6
Compare
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! Great work 🎉
Issue number: resolves internal
What is the current behavior?
ion-headerandion-footerhave acollapseprop for scroll-driven effects (condense,fade), but it only works on the iOS theme.ion-tab-barhas an unreleased hideOnScroll boolean prop that only works on the Ionic theme withexpand="compact".mdmodeWhat is the new behavior?
scrollEffectstring enum prop toion-header,ion-footer, andion-tab-bar.scrollEffect="hide"slides the bar out of view when scrolling down and back in when scrolling up.scrollEffect="condense"andscrollEffect="fade"onion-header/ion-footerreplace the existingcollapsevalues and work across all themes.collapseprop onion-headerandion-footerwith a console warning directing developers to usescrollEffect.hideOnScrollprop fromion-tab-bar.ion-tab-baris nested insideion-footer, the footer owns the hide animation to prevent double-animationmdmode was added.Does this introduce a breaking change?
Other information
Relevant Test Pages:
Header
Deprecated
collapsepropscrollEffectpropFooter
Deprecated
collapsepropscrollEffectpropTab Bar