You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: plain npx tsc --noEmit --project tsconfig.json is blocked by the existing AbortSignal declaration conflict between DOM and @types/node; the same command passes with --skipLibCheck. ESLint exits successfully, with the repository ignore warning for src/hooks/__tests__/overlay-hook-types.spec.tsx.
Hey @SSDWGG! Thanks for picking this up, and sorry for the slow reply.
The direction is right, but we went with a different implementation, so I'm going to close this one.
The componentProps argument stays optional, so a component that declares required props still type checks when you pass nothing at all, which is the most common way to get this wrong. It's the same gap the review on #29058 settled. The signature also infers the props type from componentProps, which makes the self-referencing dismiss pattern circular, so it fails with TS7022. Both v9 controller examples in our docs use that pattern, so they would stop compiling.
I opened a replacement against major-9.0, which is also where this needs to go rather than main, as we concluded on #29158, though this may not actually be able to be merged until v10 due to how close we are to v9 and it being a breaking change. You're a co-author on the new PR along with @aeharding and @liamdebeasi, since it builds on all three attempts at solving this issue. Thanks again for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28680
What is the current behavior?
useIonModalanduseIonPopoveracceptcomponentPropsasany, so props passed to typed React components are not checked.What is the new behavior?
ReactComponent<Props = any>helper while keepingReactComponentOrElementbackward-compatible.useIonModalanduseIonPopoverso component props are inferred from function/class components.Does this introduce a breaking change?
The generic defaults to
any, and JSX element overloads keep the previous permissive behavior.Testing
npm ciinpackages/reactnpm run test.spec -- --runTestsByPath src/hooks/__tests__/overlay-hook-types.spec.tsxnpx tsc --noEmit --project tsconfig.json --skipLibChecknpx prettier --check src/hooks/useIonModal.ts src/hooks/useIonPopover.ts src/hooks/__tests__/overlay-hook-types.spec.tsx src/models/ReactComponentOrElement.tsnpx eslint src/hooks/useIonModal.ts src/hooks/useIonPopover.ts src/hooks/__tests__/overlay-hook-types.spec.tsx src/models/ReactComponentOrElement.tsNote: plain
npx tsc --noEmit --project tsconfig.jsonis blocked by the existingAbortSignaldeclaration conflict between DOM and@types/node; the same command passes with--skipLibCheck. ESLint exits successfully, with the repository ignore warning forsrc/hooks/__tests__/overlay-hook-types.spec.tsx.