feat(textarea): add styles for textarea solid fill #30685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix some textarea ionic css vars usage; - create sheet for ionic.solid;
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
requested changes
Sep 22, 2025
|
|
||
| :host(.textarea-readonly) { | ||
| --background: #{globals.$ion-primitives-neutral-100}; | ||
| --background: #{globals.$ion-border-input-read-only}; |
There was a problem hiding this comment.
Suggested change
| --background: #{globals.$ion-border-input-read-only}; | |
| --background: #{globals.$ion-bg-input-read-only}; |
Comment on lines
+28
to
+30
| :host(.textarea-fill-solid) .textarea-bottom { | ||
| --border-width: #{globals.$ion-scale-0}; | ||
| } |
There was a problem hiding this comment.
Suggested change
| :host(.textarea-fill-solid) .textarea-bottom { | |
| --border-width: #{globals.$ion-scale-0}; | |
| } |
This doesn't appear to do anything
| } | ||
|
|
||
| :host(.textarea-fill-solid) .textarea-wrapper-inner { | ||
| --border-width: #{globals.$ion-border-size-050}; |
There was a problem hiding this comment.
Can we move this --border-width to the host element?
| // ---------------------------------------------------------------- | ||
|
|
||
| :host(.textarea-fill-solid.has-focus) { | ||
| --border-width: #{globals.$ion-border-size-050}; |
There was a problem hiding this comment.
Do we need to define --border-width here if it is defined on the host?
| --color: #{globals.$ion-text-disabled}; | ||
| --background: #{globals.$ion-bg-input-bold-disabled}; | ||
| --border-color: #{globals.$ion-bg-input-bold-disabled}; | ||
| --placeholder-color: #{globals.$ion-text-disabled}; |
There was a problem hiding this comment.
Shouldn't this be defined in textarea.ionic.scss since it is shared by both fills?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Does this introduce a breaking change?
Other information
fill
color
states