fix(tokens): review the generation of utility-classes #30498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenOsodrac
added
package: core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
requested changes
Jun 18, 2025
...s-snapshots/accordion-group-expand-inset-expanded-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...r.e2e.ts-snapshots/progress-bar-shape-rectangular-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...roup.e2e.ts-snapshots/accordion-group-shape-round-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
.../searchbar.e2e.ts-snapshots/searchbar-shape-round-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...st/basic/tab-bar.e2e.ts-snapshots/tab-bar-default-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...ab-bar.e2e.ts-snapshots/tab-bar-shape-rectangular-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
|
Hi @thetaPC, great point, thanks! Updated on all places 👍 |
thetaPC
requested changes
Jun 20, 2025
There was a problem hiding this comment.
This change shouldn't be happening. It seems that the test is flaky since it's happened in another PR as well. Please revert it to the original.
There was a problem hiding this comment.
It's hard to tell the shape of the accordion with the new background changes. Let's update the tests to continue using the bg color implemented in the tests.
- background: #222;
+ --background: #222;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently some utility-classes are not as effective as they could be, because they don't affect, for example, the --background or --color css API's.
What is the new behavior?
Does this introduce a breaking change?