Skip to content

feat(input-otp): add styling for the ionic theme #30465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2025
Merged

feat(input-otp): add styling for the ionic theme #30465

merged 6 commits into from
Jun 12, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jun 9, 2025

Issue number: internal


What is the current behavior?

Styles do not exist for the ionic theme.

What is the new behavior?

Adds styles for the ionic theme, splits the scss files into common and native, and adds the theme to the e2e tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Copy link

vercel bot commented Jun 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 8:59pm

@brandyscarney brandyscarney marked this pull request as ready for review June 9, 2025 20:36
@brandyscarney brandyscarney requested a review from a team as a code owner June 9, 2025 20:36
@BenOsodrac
Copy link
Contributor

LGTM 🚀

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit 911684f into next Jun 12, 2025
48 checks passed
@brandyscarney brandyscarney deleted the FW-6573 branch June 12, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants