Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): add shadow parts for background, container, and content #30069

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

fudom
Copy link
Contributor

@fudom fudom commented Dec 10, 2024

Issue number: resolves #30068


What is the current behavior?

You are not able to access parts of the toolbar. This limits you when trying to implement special behavior for your app.

What is the new behavior?

Added part attributes to toolbar for the background, container and content.

Does this introduce a breaking change?

  • Yes
  • No

@fudom fudom requested a review from a team as a code owner December 10, 2024 11:02
@fudom fudom requested a review from brandyscarney December 10, 2024 11:02
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 9:42pm

@github-actions github-actions bot added the package: core @ionic/core package label Dec 10, 2024
@brandyscarney brandyscarney changed the base branch from main to feature-8.5 January 22, 2025 21:24
@brandyscarney brandyscarney changed the title feat(toolbar) Add shadow parts feat(toolbar): add shadow parts for background, container, and content Jan 22, 2025
@brandyscarney brandyscarney requested a review from thetaPC January 22, 2025 22:07
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit ac4ea32 into ionic-team:feature-8.5 Jan 23, 2025
48 checks passed
@brandyscarney
Copy link
Member

Thank you for the PR! This will be in the 8.5.0 release. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Make toolbar-container selectable via shadow part
3 participants