Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toggle): add iOS 18 haptic feedback #29945

Open
wants to merge 8 commits into
base: feature-8.6
Choose a base branch
from
+9 −0
Open

feat(toggle): add iOS 18 haptic feedback #29945

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b29e007
feat(toggle): add ios 18 haptic feedback
jedlikowski Oct 17, 2024
1822dc3
feat(toggle): make iOS haptic feedback configurable
jedlikowski Oct 18, 2024
156578b
Merge branch 'main' into 29942-ios-18-toggle-haptic-feedback
jedlikowski Mar 18, 2025
88de124
Merge branch 'feature-8.6' of github.com:ionic-team/ionic-framework i…
thetaPC Mar 31, 2025
0c3eb4d
Merge branch 'feature-8.6' of github.com:ionic-team/ionic-framework i…
thetaPC Mar 31, 2025
cc1d892
refactor(toggle): use hapticSelection on onClick
thetaPC Apr 1, 2025
5c32966
chore(toggle): revert changes
thetaPC Apr 2, 2025
c7e2f65
Update core/src/components/toggle/toggle.tsx
thetaPC Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/components/toggle/toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Component, Element, Event, Host, Prop, State, Watch, h } from '@stencil
import { renderHiddenInput, inheritAriaAttributes } from '@utils/helpers';
import type { Attributes } from '@utils/helpers';
import { hapticSelection } from '@utils/native/haptic';
import { isPlatform } from '@utils/platform';
import { isRTL } from '@utils/rtl';
import { createColorClasses, hostContext } from '@utils/theme';
import { checkmarkOutline, removeOutline, ellipseOutline } from 'ionicons/icons';
Expand Down Expand Up @@ -247,6 +248,13 @@ export class Toggle implements ComponentInterface {
}

private onClick = (ev: MouseEvent) => {
/**
* The haptics for the toggle on tap is
* an iOS-only feature. As such, it should
* only trigger on iOS.
*/
const enableHaptics = isPlatform('ios');

if (this.disabled) {
return;
}
Expand All @@ -255,6 +263,7 @@ export class Toggle implements ComponentInterface {

if (this.lastDrag + 300 < Date.now()) {
this.toggleChecked();
enableHaptics && hapticSelection();
}
};

Expand Down
Loading