[feature] Allow using of the complex attribute names for encryptedNative and protectedNative
#3032
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces changes to support complex attribute names for the encrypted and protected native configuration properties by updating how attributes are accessed, set, and deleted. Key changes include replacing direct property access with helper functions (getObjectAttribute, setObjectAttribute, deleteObjectAttribute) and updating tests to verify that complex attributes (such as "complex.password") are handled correctly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/adapter/src/lib/adapter/utils.ts | Updated helper functions to support complex attribute names by adding wrapper functions for get, set, and delete operations. |
| packages/adapter/src/lib/adapter/adapter.ts | Revised usage of attribute access in encryption/decryption flows and protected native deletion to use the new helper functions. |
| packages/controller/test/lib/testObjectsFunctions.ts packages/controller/test/lib/testAdapterHelpers.ts |
Updated tests to include complex attribute scenarios for encryption and protection. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This PR looks like a solution to #846 (or at least as related to that issue). @GermanBluefox please confirm and check that this issue is covered by the PR changes. Especially encryption of array related elements liek table fileds should be implemented too when changes are made to this area. |
This solves only second part of requirement |
…rotected native configuration properties: `encryptedNative` and `protectedNative` with arrays
|
This PR can now encrypt passwords in arrays |
Some adapters, like "email" have complex attribute paths, like
transportOptions.auth.passit is not possible to useprotectedNativeandencryptedNativefor that.For Features:
Tests
Documentation
No documentation required