feat: better graph validation errors #7614
Open
+43
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
InvalidEdgeError
, ensure we use that error message.Before:
After:
Related Issues / Discussions
Should help in troubleshooting the issue here https://discord.com/channels/1020123559063990373/1083864753543331981/1334888935242858506
QA Instructions
@skunkworxdark Could you please try reproducing that issue with this PR? Hopefully it's easier to see what's going on.
For this specific issue, might need to set breakpoints for each of the 3 fail case returns in these two methods in
graph.py
to get the full picture:Graph._is_iterator_connection_valid()
Graph._is_collector_connection_valid()
Merge Plan
n/a
Checklist
What's New
copy (if doing a release after this PR)