Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better graph validation errors #7614

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • When validating edges, return the error message instead of just a boolean.
  • When raising InvalidEdgeError, ensure we use that error message.
  • Surface the error message to the user in the UI.
  • Tweak the error toast to be a bit less cryptic.

Before:
image

After:
image

Related Issues / Discussions

Should help in troubleshooting the issue here https://discord.com/channels/1020123559063990373/1083864753543331981/1334888935242858506

QA Instructions

@skunkworxdark Could you please try reproducing that issue with this PR? Hopefully it's easier to see what's going on.

For this specific issue, might need to set breakpoints for each of the 3 fail case returns in these two methods in graph.py to get the full picture:

  • Graph._is_iterator_connection_valid()
  • Graph._is_collector_connection_valid()

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@psychedelicious psychedelicious changed the title Psyche/feat/nodes/better iterator error feat: better graph validation errors Feb 4, 2025
@github-actions github-actions bot added python PRs that change python files services PRs that change app services frontend PRs that change frontend files labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files python PRs that change python files services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants