Skip to content

ci: add turbo and release workflow #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 28, 2025
Merged

ci: add turbo and release workflow #184

merged 15 commits into from
Jul 28, 2025

Conversation

cabljac
Copy link
Collaborator

@cabljac cabljac commented May 12, 2025

This PR:

  • sets up Turborepo for task management and adds automated release workflows using Changesets.
  • It updates CI/CD configurations to include format checks, testing with Firebase emulators, and a release process.

Copy link

docs-page bot commented May 12, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~184

Documentation is deployed and generated using docs.page.

@cabljac cabljac requested a review from Copilot July 10, 2025 10:50
Copilot

This comment was marked as outdated.

@cabljac cabljac force-pushed the release-workflow branch from 4a8aebf to d28c017 Compare July 10, 2025 10:53
@cabljac cabljac requested a review from Copilot July 10, 2025 12:56
Copilot

This comment was marked as outdated.

@cabljac cabljac changed the title ci(Draft): add turbo and release workflow ci: add turbo and release workflow Jul 14, 2025
@cabljac cabljac requested a review from Copilot July 14, 2025 11:43
Copilot

This comment was marked as outdated.

@cabljac cabljac marked this pull request as ready for review July 14, 2025 12:02
@cabljac cabljac requested a review from HassanBahati July 14, 2025 12:02
@cabljac cabljac requested review from Copilot and HassanBahati July 14, 2025 15:37
Copilot

This comment was marked as outdated.

@cabljac cabljac requested a review from Copilot July 28, 2025 08:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up Turborepo for task management and adds automated release workflows using Changesets. It updates CI/CD configurations to include format checks, testing with Firebase emulators, and a release process.

  • Added Turborepo configuration for monorepo task management
  • Implemented Changesets for automated versioning and publishing
  • Updated CI/CD workflows with format checking and emulator-based testing

Reviewed Changes

Copilot reviewed 87 out of 99 changed files in this pull request and generated no comments.

Show a summary per file
File Description
turbo.json Defines Turborepo task configuration with build, test, and format tasks
.github/workflows/tests.yaml Updated CI workflow with quality checks and emulator-based testing
.github/workflows/release.yml New automated release workflow using Changesets
.changeset/ Changeset configuration and initial changeset for CI improvements
package.json Added Turborepo, Changesets, and updated scripts for new workflow
biome.json Enhanced Biome configuration with better file handling and formatting rules
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (7)

packages/react/src/firestore/useNamedQuery.ts:16

  • [nitpick] The parameter name '_AppModelType' uses an underscore prefix to indicate it's unused, but the naming convention should be consistent with the next parameter. Consider using 'AppModelType' or ensure consistent underscore prefixing.
  _AppModelType = DocumentData,

packages/react/src/firestore/useNamedQuery.ts:17

  • [nitpick] The parameter name '_DbModelType' should follow the same naming convention as '_AppModelType' on the previous line. Both should either use underscores or not.
  _DbModelType extends DocumentData = DocumentData,

packages/react/src/auth/utils.ts:12

  • [nitpick] The parameter '_email' is prefixed with underscore to indicate it's unused, but this creates inconsistency with other function parameters that are not prefixed. Consider using a more descriptive name or consistent naming convention.
  _email: string,

packages/react/src/auth/useDeleteUserMutation.ts:16

  • The parameter '_auth' is prefixed with underscore but appears to be genuinely unused in the function body. Consider removing this parameter if it's not needed for the API contract.
  _auth: Auth,

packages/react/src/data-connect/useDataConnectMutation.test.tsx:390

  • [nitpick] The parameter '_index' is prefixed with underscore to indicate it's unused. This is a good practice, but consider using a more descriptive name like '_i' or simply omitting the parameter name if it's not used.
    const deleteData = createdMovies.map((movie, _index) => ({

packages/angular/src/data-connect/injectDataConnectMutation.test.ts:362

  • [nitpick] The parameter '_index' is prefixed with underscore to indicate it's unused. This follows the same pattern as in the React tests and is acceptable for indicating unused parameters.
    const deleteData = createdMovies.map((movie, _index) => ({

functions/src/index.js:10

  • [nitpick] The parameter '_data' is prefixed with underscore to indicate it's unused. This is consistent with the convention used elsewhere in the codebase.
module.exports.getJoke = functions.https.onCall(async (_data) => {

@cabljac cabljac merged commit b807700 into main Jul 28, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Open Source P0 Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants