Skip to content

Conversation

@mikehardy
Copy link
Collaborator

Description

prevents LRU eviction thrashing of caches since we are near the limit on useful caches for a single CI run

This is a follow-on to the CI perf tuning PR from a few days back, it was the only thing I noticed that wasn't perfect after merging that one - we are saving lots of ccache's, mostly from branches, and it LRUs out useful main-branch caches

Related issues

Release Summary

test only, and just perf on test even - no release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Look at the caches page after this is implemented, and we should no longer see caches from non-branch that start with ccache https://github.com/invertase/react-native-firebase/actions/caches

Additionally, after other branches update to this workflow or run them and it has been a while, we will hopefully stop seeing our cacches expire so frequently - many of them should be pretty long-lived (weeks+, not just hours/days)


Think react-native-firebase is great? Please consider supporting the project with any of the below:

prevents LRU eviction thrashing of caches since we are near the limit
on useful caches for a single CI run
@vercel
Copy link

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
react-native-firebase Ready Ready Preview, Comment Jan 5, 2026 5:03pm

@mikehardy mikehardy added Type: Testing Issues or PRs relating to testing (the library or user code testing) tools: ci labels Jan 5, 2026
@mikehardy
Copy link
Collaborator Author

mikehardy commented Jan 5, 2026

Not saving cache because 'save' is set to 'false'.

worked (example https://github.com/invertase/react-native-firebase/actions/runs/20722896996/job/59491170948?pr=8822#step:75:28)

will verify main saves post-merge

@mikehardy mikehardy merged commit a2844d4 into main Jan 5, 2026
21 checks passed
@mikehardy mikehardy deleted the @mikehardy/ccache-save-main-only branch January 5, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Attention tools: ci Type: Testing Issues or PRs relating to testing (the library or user code testing)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants