[messaging] Enhance Expo notification icon configuration support and documentation #8618
+327
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #8616 by significantly improving the documentation and developer experience for the existing Expo notification icon configuration feature in @react-native-firebase/messaging.
The messaging package already includes an Expo config plugin (added in v18.7.0 via #7369) that automatically configures Firebase notification icons and colors from
app.json
, but this functionality was poorly documented and largely unknown to users.Changes Made
📚 Enhanced Documentation
docs/messaging/usage/index.md
with comprehensive Expo configuration section including:app.json
configurationpackages/messaging/README.md
with clear Expo setup instructions and examplepackages/messaging/EXPO_EXAMPLE.md
with detailed examples and best practices🔧 Improved Developer Experience
[@react-native-firebase/messaging]
✅ Enhanced Testing
How It Works
The existing Expo plugin automatically:
expo.notification.icon
andexpo.notification.color
fromapp.json
com.google.firebase.messaging.default_notification_icon
com.google.firebase.messaging.default_notification_color
Example Configuration
Before vs After
Before: Users were unaware this feature existed and requested it as a new feature
After: Clear documentation and improved messaging make the feature discoverable and easy to use
Testing
This PR transforms an existing but hidden feature into a well-documented, user-friendly solution that fully addresses the feature request in #8616.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
docs.expo.dev
curl -s REDACTED
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.