-
Couldn't load subscription status.
- Fork 2.3k
feat(auth): add support for fullName when using Sign in with Apple #8570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(auth): add support for fullName when using Sign in with Apple #8570
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting! This looks great - I want to think on it for just a little bit, what I'm curious about is if there is any way to allow the new AppleCredential (with full name extras) can simply go in to the existing API, and the code can dynamically check if the fullname exists and do the correct thing in the native module
More important than that is to consult the firebase-js-sdk to see if they have any applicable APIs, I haven't checked yet but in general if they have anything that handles this, we'll follow them exactly so we maintain status as a drop-in replacement
|
Just wanted to offer some status here @andrewdollard - I'm about to release react-native-firebase to dequeue the SDK updates and some other fixes we've got, then this moves up on the list of things to give some attention - I still have the same questions as before (which I need to think about) but I really appreciate the PR in general and just wanted you to know it's not forgotten by any stretch |
|
Thanks for the update @mikehardy. Happy to look into the questions you raised as well, as soon as I get a chance (hopefully this week) |
Description
Adds the ability to set the user's full name when using Sign In With Apple.
When signing in with Apple using e.g.
react-native-apple-authentication, Apple provides afullNamevalue which must be displayed in the app; furthermore, Apple provides this data only on initial sign-up and not on subsequent sign-ins.firebase-ios-sdksupports setting that value when signing in via Firebase with an Apple credential; however,react-native-firebasedoes not currently provide a way to pass thefullNamevalue to the underlying Firebase native code. As a result, using Sign In With Apple requires storing the user's name data in the app instead of in Firebase as with other social auth providers.This PR adds a
signInWithAppleCredentialmethod to theauthmodule, which passes thefullNamevalue toappleCredentialWithIDTokenin the Firebase iOS SDK so it can be forwarded to Firebase on sign-up.Notes:
AppleAuthProvider.credentialis extended to take an optionalfullNameparametersignInWithAppleCredentialaccepts a credential with or without thefullNamepropertysignInWithCredentialmethod is unchangedThis feature is iOS only; AFAICT this functionality is already handled by the Firebase Android SDK (docs).
Related issues
Fixes #7603
Release Summary
Adds ability to set
fullNamewhen using Sign In With AppleChecklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
I wasn't able to add e2e tests as the Firebase emulator doesn't support social auth, but I am running it in my own app:
🔥
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter