fix(analytics): Type defs

[MichaelVerdon]

Description

Related issues

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 24, 2025 3:02pm

[mikehardy]

• potential for actual implementation on web just by hooking up web plumbing
• return value question

[mikehardy]

for web we have an implementation already (I'm aware because I was in there semi-recently - it works...)

react-native-firebase/packages/analytics/lib/web/api.js

Line 165 in 8f59579

async _getCid() {

if you haven't done it, running yarn tests:macos:pod:install && yarn tests:macos:build && yarn tests:macos:test-cover runs the "web" version, and if you put an it.only or describe.only on any part of the e2e suite it'll run just those so it's fast to test+iterate

shame not to expose it since that might be half the work that went into the "other" platform analytics!

[mikehardy]

...but, @returns {string} 🤔 ?

[MichaelVerdon]

This was put there temporarily so the linter wouldn't get angry at me.

[github-actions]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.62%. Comparing base (1126f2f) to head (7651c99).
Report is 82 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8363      +/-   ##
==========================================
- Coverage   71.28%   70.62%   -0.66%     
==========================================
  Files         159      187      +28     
  Lines        6597     7905    +1308     
  Branches     1521     1838     +317     
==========================================
+ Hits         4702     5582     +880     
- Misses       1771     2129     +358     
- Partials      124      194      +70     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.