fix: Flaky tests when run in GitHub Actions Workflow #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicatarra
changed the title
jessicatarra
force-pushed
the
test/fix-flaky-tests
branch
2 times, most recently
from
f1e7d69 to
ca1604c
Compare
- Remove unnecessary TODO comment in the workflow file - Update test command in workflow to remove unnecessary `|| true` - Update dependency messages matcher in `matchers.dart` test file
jessicatarra
force-pushed
the
test/fix-flaky-tests
branch
from
ca1604c to
b3745c4
Compare
spydon
approved these changes
Jun 26, 2024
|
Super, thanks! Windows still seems to fail, but that might be unrelated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey everyone! I initially attempted to resolve this issue by following the approach mentioned in this issue by setting the environment variable
PUB_SUMMARY_ONLY=1in the workflow. However, this did not work as expected.Then, I decided to solve it by updating the
ignoringDependencyMessagesmethod in the matcher file, and this approach seems to be working fine.Changes:
|| truematchers.darttest fileIssue: #724
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore