fix: improve ios bundleID regex to stop bundleIDs from throwing incorrectly #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
Needs Attention
EArminjon
force-pushed
the
fix-ios-bundle-id-regex
branch
from
fcf2840 to
ccafdbf
Compare
russellwheatley
changed the title
EArminjon
had a problem deploying
to
CI Environment
GitHub Actions
Failure
EArminjon
had a problem deploying
to
CI Environment
GitHub Actions
Failure
EArminjon
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
@russellwheatley CI failed weirdly : jobs has been canceled, what can i do to fix that ? |
|
@EArminjon - I will update the PR 👍 |
russellwheatley
had a problem deploying
to
CI Environment
GitHub Actions
Failure
russellwheatley
had a problem deploying
to
CI Environment
GitHub Actions
Failure
russellwheatley
had a problem deploying
to
CI Environment
GitHub Actions
Failure
russellwheatley
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
@EArminjon - Pull requests that fork the repo will cause the CI to fail. I've just ran it locally, and it passed. I've updated the contributing documentation to ask users to clone rather than fork 👍
|
Thanks a lot, will use that as soon as you release it ;) ! |
|
Hello @russellwheatley , Can you release it on pub.dev please :) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR try to fix #352
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore