-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Regression - ValidationException: ios - Invalid Apple App Bundle ID #352
Comments
Regex here is not good :
Should accept single word bundle id. I got 2 applications using a single word as bundle id : "webshop" (Rexel FR) and "RexelSE" (Rexel SE). Both are published since a while on App Store. |
If you would like to open a PR with the updated regex, I'd take a look. Ideally create unit tests with a list of valid and invalid bundle ids here: https://github.com/invertase/flutterfire_cli/blob/main/packages/flutterfire_cli/test/unit_tests.dart |
Done ;) |
Actually my project is for iOS/Android only and has bundle id in com.bundle.id format, but in our makefile with commands we were passing "placeholder" as bundle id parameter for web, mac and windows, which caused an error. Anyways this thread helped me to identify the issue, TY very much! |
Is there an existing issue for this?
CLI Version
1.0.1-dev.4
Firebase Tools version
10.8.0
Flutter Doctor Output
[✓] Flutter (Channel stable, 3.24.3, on macOS 15.2 24C101 darwin-arm64, locale fr-FR)
• Flutter version 3.24.3 on channel stable at /Users/earminjon/fvm/versions/3.24.3
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 2663184aa7 (4 months ago), 2024-09-11 16:27:48 -0500
• Engine revision 36335019a8
• Dart version 3.5.3
• DevTools version 2.37.3
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
• Android SDK at /Users/earminjon/Library/Android/Sdk
• Platform android-35, build-tools 35.0.0
• ANDROID_HOME = /Users/earminjon/Library/Android/Sdk
• Java binary at: /Users/earminjon/Library/Java/JavaVirtualMachines/corretto-17.0.13/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment Corretto-17.0.13.11.1 (build 17.0.13+11-LTS)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 16.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 16C5032a
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.2)
• Android Studio at /Users/earminjon/Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)
[✓] Android Studio (version 2023.2)
• Android Studio at /Users/perso/Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
[✓] IntelliJ IDEA Ultimate Edition (version 2024.3.1.1)
• IntelliJ at /Users/earminjon/Applications/IntelliJ IDEA Ultimate.app
• Flutter plugin version 83.0.4
• Dart plugin version 243.23177
Description
iOS bundle id are not working when the id is a single word, example "webshop".
It works fine using version 1.0.0
Steps to reproduce
Having an iOS bundle id with only one word
Expected behavior
It should works.
Screenshots
No response
Additional context and comments
No response
The text was updated successfully, but these errors were encountered: