Check the exit code from npm processes #28
Conversation
|
@alexsdutton This looks really nice! Thanks for the fix! Could you squash the commits please? I notice it is a "draft" PR, could you make it into a normal PR once is ready to be reviewed? Thanks again! |
|
Draft> Yep. I haven't yet got the tests working locally, so was going to do that, and then add a test with a contrived npm script faulure. If you're happy to have it without the additional test then that's fine and I'll squash and de-draft it :-) |
Without this, npm errors pass silently, potentially leading to 'successful' incomplete webpack builds. Also adds a test that takes the simple project, removes a necessary file, and checks whether the build is reported as failing.
|
@alexsdutton what you describe sounds nice! tests are <3 Thanks! Just FYI, this is related to inveniosoftware/pynpm#6 |
|
@ppanero Test added, and ready for review. :-) |
| @@ -87,6 +88,14 @@ def test_project_no_scripts(brokenprj): | |||
| project.buildall() | |||
|
|
|||
|
|
|||
| def test_project_failed_build(simpleprj): | |||
| # Remove a file necessary for the build | |||
| os.unlink(os.path.join(os.path.dirname(simpleprj), 'index.js')) | |||
There was a problem hiding this comment.
Since simpleprj does not define a scope, it is function. However, if that were to change in the future this could break other tests since it is not linked again.
I am not against leaving it as is, since it shouldn't change. However, it is breaking a fixture purposely 😅 Let's see what others think @ntarocco @fenekku @slint
There was a problem hiding this comment.
I see your point, it might happen true. In my opinion we can leave it like this and eventually fix it in the future.
|
@alexsdutton I have merged your PR, thanks a lot for your contribution. |
|
Thanks for reviewing and accepting it, @ntarocco! My employer, Cottage Labs LLP (@CottageLabs), will be the copyright holder for all my contributions to Invenio organisation repositories. |
Without this, npm errors pass silently, potentially leading to 'successful' incomplete webpack builds.