wip #111
Merged
wip #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utnapischtim
force-pushed
the
remove-flask-upper-pin
branch
3 times, most recently
from
ec962f3 to
d707471
Compare
utnapischtim
force-pushed
the
remove-flask-upper-pin
branch
3 times, most recently
from
f26d81e to
d5fa6a3
Compare
* upgrade pytest to remove a lot of warnings with no api impact on the tests
utnapischtim
force-pushed
the
remove-flask-upper-pin
branch
from
d5fa6a3 to
0e177ca
Compare
utnapischtim
force-pushed
the
remove-flask-upper-pin
branch
from
0e177ca to
1156768
Compare
* fix DeprecationWarning about not implemented abstract methods * fix test_db. db.session.commit() commits to database which makes it impossible to rollback the session and therefore the second test fails with the counts * fix pydocstyle error
utnapischtim
force-pushed
the
remove-flask-upper-pin
branch
from
1156768 to
2d2d903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR needs invenio-files-rest, invenio-db, invenio-base released first
DISCUSSION:
is it a good idea that a pytest package which is used to test other packages needs invenio packages to be tested? it feels strange to update first invenio-files-rest so that i can update pytest-invenio. not only that it feels wrong it could also create a test deadlock