Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check return code (raise if non-zero) #6

Open
fenekku opened this issue Feb 21, 2020 · 0 comments
Open

Check return code (raise if non-zero) #6

fenekku opened this issue Feb 21, 2020 · 0 comments
Labels

Comments

@fenekku
Copy link

fenekku commented Feb 21, 2020

When the underlying npm call fails, the python script using pynpm still returns as if everything went well. This came up when invenio webpack build failed on us in InvenioRDM.

Probably need to change the calls there:

https://github.com/inveniosoftware/pynpm/blob/master/pynpm/utils.py#L19

to check_call (with Popen it's up to the developer to deal with it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants