Migrate to GH Actions #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthS007
reviewed
Dec 9, 2020
| - name: Set up Python | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: 3.7 |
There was a problem hiding this comment.
Minor: It can be 3.8 so we are always using the latest version for release.
.github/workflows/tests.yml
Outdated
|
|
||
| - name: Run tests | ||
| run: | | ||
| ./run-tests.sh |
MANIFEST.in
Outdated
| @@ -24,3 +24,4 @@ include .lgtm | |||
| include LICENSE | |||
| include MAINTAINERS | |||
| global-exclude *.py[cod] __pycache__ *.so | |||
| recursive-include .github/workflows *.yml | |||
| @@ -9,4 +9,5 @@ | |||
|
|
|||
|
|
|||
| [pytest] | |||
| addopts = --pep8 --ignore=docs --cov=jsonresolver --cov-report=term-missing tests jsonresolver | |||
| addopts = --isort --pydocstyle --pycodestyle --doctest-glob="*.rst" --doctest-modules --cov=jsonresolver --cov-report=term-missing | |||
| testpaths = tests jsonresolver | |||
run-tests.sh
Outdated
| python -m check_manifest --ignore ".*-requirements.txt" | ||
| python -m sphinx.cmd.build -qnNW docs docs/_build/html | ||
| python -m pytest | ||
| python -m sphinx.cmd.build -qnNW -b doctest docs docs/_build/doctest |
setup.py
Outdated
| 'pytest-pep8>=1.0.6', | ||
| 'pytest>=3.6.0', | ||
| 'requests>=2.7.0', | ||
| "mock>=1.3.0", |
There was a problem hiding this comment.
Minor: Replace " with ' to maintain uniformity.
| "pydocstyle>=1.0.0", | ||
| "pytest-cache>=1.0", | ||
| "requests>=2.7.0", | ||
| "pytest-invenio>=1.4.0" | ||
| ] | ||
|
|
||
| extras_require = { |
There was a problem hiding this comment.
Minor: Sphinx version can be >=3
avivace
force-pushed
the
ga-migration
branch
2 times, most recently
from
ccf04cf to
9055c77
Compare
|
@ParthS007 Great, thanks. Everything should be fixed (but the quotes minor issue) |
ParthS007
approved these changes
Dec 9, 2020
diegodelemos
reviewed
Dec 9, 2020
.github/workflows/pypi-publish.yml
Outdated
| - name: Build package | ||
| # Remove `compile_catalog` if the package has no translations. | ||
| run: | | ||
| python setup.py compile_catalog sdist bdist_wheel |
There was a problem hiding this comment.
This module doesn't have translations (according to previous .travis.yml)
Suggested change
| python setup.py compile_catalog sdist bdist_wheel | |
| python setup.py sdist bdist_wheel |
diegodelemos
reviewed
Dec 9, 2020
| # | ||
| # jsonresolver is free software; you can redistribute it and/or modify | ||
| # it under the terms of the Revised BSD License; see LICENSE file for |
There was a problem hiding this comment.
We should leave Revised BSD License license header :)
avivace
force-pushed
the
ga-migration
branch
from
d3a85e1 to
85aba52
Compare
avivace
force-pushed
the
ga-migration
branch
from
85aba52 to
0710f93
Compare
|
Created issue to keep track of failing tests #28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was prepared by an automated action. Closes #25