Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of the user admin #82

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Draft of the user admin #82

merged 2 commits into from
Jul 7, 2023

Conversation

psaiz
Copy link
Contributor

@psaiz psaiz commented Jun 21, 2023

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@psaiz
Copy link
Contributor Author

psaiz commented Jun 21, 2023

I left it as a draft, since I didn't add any tests, and there is one comment in the code that I do not understand :(

@kpsherva kpsherva marked this pull request as ready for review June 21, 2023 13:51
@psaiz
Copy link
Contributor Author

psaiz commented Jun 21, 2023

Here are a couple of screenshots
Screenshot 2023-06-21 at 16 49 40
Screenshot 2023-06-21 at 16 34 06

Copy link
Contributor

@max-moser max-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor details, although not all of them are necessary

@@ -36,41 +36,27 @@ jobs:
python-version: [3.7, 3.8, 3.9]
requirements-level: [pypi]
cache-service: [redis]
db-service: [postgresql10, postgresql13, mysql5, mysql8]
db-service: [postgresql10, postgresql13]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzacharo, please check this change! The main issue is that mysql is not happy with the table of vocabularies. If I get it right, the trigger for this is that now the module also depends in invenio-administration, and that brings its dependencies (invenio-vocabularies in particular). Note that neitherinvenio-administration nor invenio-vocabularies do not check the mysql pipelines. I have the feeling that they did, they would have the same issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following @jrcastro2 suggestion, another option would be to put something like inveniosoftware/invenio-vocabularies#261

@zzacharo zzacharo merged commit 804897a into inveniosoftware:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

administration: add user management panel
5 participants