files: remove HTTP code from read_content #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_file
might be issuing, resulting in odd situations when the storage layer returns a 302, i.e. offload download.When an instance uses local storage, eventually send_file gets called and the file is streamed through the application server.
If one uses Invenio-S3, instead of serving the file directly, the application issues a redirect to a short-lived signed URL, relaying the work of streaming the file to the storage server, offloading.
The problem is that send_file itself returns a response with its own response code, etc. The 200 here basically overwrites that response code and the redirect doesn't work.
We don't experience that same behavior with EOS because the redirect is happening at nginx level using X-Accel-Redirect.