schema: fix data reference update in pre_load #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcastro2
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
LGTM! Thanks a lot for this fix 🚀 I think it would be good if we can fix it in all other places that manipulate the data using the pre_load, such as here
I would check in all places and apply the same fix so that we don't waste time in the future with this issue 😉
zzacharo
reviewed
Feb 15, 2024
yashlamba
force-pushed
the
schema-fix
branch
from
65d633c to
3cc509a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to an issue with marshmallow that they are not freezing the original data which causes potential modifications leading to an updated copy of the object on subsequent pre/validate/post calls.
https://github.com/marshmallow-code/marshmallow/blob/13a12ad2eed262933770c643febbc46d4905c4c9/src/marshmallow/schema.py#L851-L853
This is work around for that for this specific case inveniosoftware/invenio-communities#1088 where we need to use
pass_original.