Skip to content

Commit

Permalink
fix: unable to delete unfinalized multipart upload
Browse files Browse the repository at this point in the history
  • Loading branch information
mesemus committed Feb 24, 2025
1 parent 66de966 commit ad4e195
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
7 changes: 6 additions & 1 deletion invenio_records_resources/services/files/transfer/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@
"""Base transfer class."""

from abc import ABC
from typing import Union

from flask_babel import lazy_gettext as _
from fs.errors import CreateFailed
from invenio_files_rest.errors import FileSizeError
from werkzeug.exceptions import ClientDisconnected

from invenio_records_resources.records.api import Record
from invenio_records_resources.records.api import FileRecord, Record
from invenio_records_resources.services.errors import TransferException
from invenio_records_resources.services.files.service import FileService

Expand Down Expand Up @@ -52,12 +53,14 @@ def __init__(
record: Record,
key: str,
file_service: FileService,
file_record: Union[FileRecord, None] = None,
uow=None,
):
"""Constructor."""
self.record = record
self.key = key
self.file_service = file_service
self._file_record = file_record # need to store it as it might be deleted
self.uow = uow

def init_file(self, record, file_metadata):
Expand All @@ -73,6 +76,8 @@ def init_file(self, record, file_metadata):
@property
def file_record(self):
"""Get the file record."""
if self._file_record:
return self._file_record
return self.record.files[self.key]

def set_file_content(self, stream, content_length):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,9 @@ def get_transfer(
raise ValueError("Either file_record or transfer_type must be provided.")

return self._transfers[transfer_type](
record=record, key=key, file_service=file_service, uow=uow
record=record,
key=key,
file_service=file_service,
file_record=file_record,
uow=uow,
)

0 comments on commit ad4e195

Please sign in to comment.