Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added overridable blocks and passing serializing functions as props #1970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ducica
Copy link

@Ducica Ducica commented Mar 7, 2025

❤️ Thank you for your contribution!

Description

We would like to use the creatibutor component for our apps as well. Generally, we really like the look/functionality. We only have small issue, because it is not possible to make any, relevant customizations. This PR keeps 100% the current behavior of the app. The only change is:

  1. Added overridable blocks (for our case, certain things as affiliations for the Organizational type of creatibutors does not make sense).
  2. Passing three functions as props (to serializeSuggestions, and to serialize and deserialize creatibutors). These are by default undefined and the ones already existing are used by default.
    The issue can be for example, we have more types of identifiers and also our static folder might have different structure (for icons and such).

We would really appreciate if you would consider merging this. I think it could be beneficial also for other users/partners of invenio.

Please let us know and thank you!

Dusan Stojanovic (CESNET).

@Ducica Ducica marked this pull request as ready for review March 7, 2025 09:44
@Ducica
Copy link
Author

Ducica commented Mar 7, 2025

@zzacharo @ntarocco Hey guys, we've made a small PR for the creatibutors component. If it is possible to take a look at it please and let us know if this is something you would consider merging. Even if not, kindly give feedback (yes/no) in any case, as we need to take a different direction if merging this will not be possible. Naturally we would prefer not to have 95% copy of this component ourselves, so it would be really great if we could merge it. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant