ui: rename the run button #68
Conversation
anikachurilova
force-pushed
the
harvester-reader
branch
2 times, most recently
from
247ef90 to
57a7df7
Compare
| {(props) => { | ||
| const actions_errors = props?.errors | ||
| const args = props?.values?.args; | ||
| let cleanedArgs = undefined; |
There was a problem hiding this comment.
Needed to clean up the values because of the problem in this scenario:
- input incorrect date into one of the fields
- remove everything from that input field and fill in another field
- the first field is not
nullnow, but an empty string (because formik) - empty string is not a valid date --> validation failed
There was a problem hiding this comment.
are you sure there is nothing in formik that could help with that? I think there was something related to touched values.
There was a problem hiding this comment.
There is a touched field, but it just indicates if the field was touched or not, I would still need to implement the logic of cleaning up the value. Maybe I am missing something, but I didn't see anything useful for this in Formik.
There was a problem hiding this comment.
it would be more proper to clean the values using formik states and methods. Doing it in the render function, you clean it up every time component is re-rendered.
Let's use the formik API: https://formik.org/docs/api/formik one of the functions, onSubmit, validate maybe? to clean only the touched and empty values and only before sending it to the backend
There was a problem hiding this comment.
| @@ -151,6 +162,11 @@ export class RunActionForm extends Component { | |||
| {!isEmpty(error) && ( | |||
| <ErrorMessage | |||
| {...error} | |||
| content={ | |||
| actions_errors && Object.keys(actions_errors).length > 0 | |||
There was a problem hiding this comment.
Added this in order to be able to display the exact error message of a marshmallow validation in the UI. The info is already there, just need to display it on the page now. Here is where it gets populated: https://github.com/inveniosoftware/invenio-administration/blob/main/invenio_administration/assets/semantic-ui/js/invenio_administration/src/formik/ActionForm.js#L119
Before:
After:
anikachurilova
force-pushed
the
harvester-reader
branch
from
57a7df7 to
e2202c3
Compare
anikachurilova
force-pushed
the
harvester-reader
branch
from
e2202c3 to
c3e1c93
Compare
| @@ -151,6 +152,11 @@ export class RunActionForm extends Component { | |||
| {!isEmpty(error) && ( | |||
| <ErrorMessage | |||
| {...error} | |||
| content={ | |||
| actions_errors && Object.keys(actions_errors).length > 0 | |||
| ? Object.values(actions_errors)[0] | |||
There was a problem hiding this comment.
Is it possible to have more than one error ? Would it make sense to display all of them?
| @@ -46,7 +46,8 @@ class JobsAdminMixin: | |||
| "icon": "calendar", | |||
| }, | |||
| "runs": { | |||
| "text": "Run now", | |||
| "text": "Configure and run", | |||
There was a problem hiding this comment.
| "text": "Configure and run", | |
| "text": "Configure run", |
There was a problem hiding this comment.
I don't think this indicates that this is where you would run the job. "Configure and run" seems clearer to me.
Before, it was not clear that the "Run now" button is opening a modal with configs and not immediately running the job.