-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Update RichEditor to use inputValue #1185
Editor: Update RichEditor to use inputValue #1185
Conversation
2536b44
to
f8c5f91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically the same change as in inveniosoftware/react-invenio-forms#249, which fixed an issue where the editor lost its content when it lost focus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with some quick testing (of the community member invitation modal) on a local v13 i couldn't find the issue of the editor losing content when losing focus.
however, i could find this issue in a v12 setup and this PR (backported) fixed that.
on v13, i could not detect any adverse effects with this PR.
acf2449
to
c190662
Compare
From my testing, this issue appears to be flaky, it sometimes works and sometimes doesn't, which was confusing. Therefore, I've decided to keep this change for now, as it guarantees the functionality. |
alright, thanks for the extra infos! |
❤️ Thank you for your contribution!
Description
This will fix the editor's loss of content after losing focus in communities invite modal
Closes inveniosoftware/invenio-app-rdm#2771
Related to inveniosoftware/react-invenio-forms#249
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: