-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
horizon: community home page #1081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8142b4d
to
38d000d
Compare
38d000d
to
a73bd1a
Compare
kpsherva
reviewed
Feb 6, 2024
invenio_communities/templates/semantic-ui/invenio_communities/community_theme_template.css
Outdated
Show resolved
Hide resolved
a73bd1a
to
e5a6699
Compare
4b49f76
to
4b0d854
Compare
d6bc416
to
9c7cb8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We left multiple questions.
Also, tests are failing. Can you have a look, please?
invenio_communities/templates/semantic-ui/invenio_communities/details/home/index.html
Outdated
Show resolved
Hide resolved
invenio_communities/templates/semantic-ui/invenio_communities/details/home/index.html
Outdated
Show resolved
Hide resolved
invenio_communities/templates/semantic-ui/invenio_communities/details/home/index.html
Outdated
Show resolved
Hide resolved
4e0e8ce
to
660eae2
Compare
* moved to invenio_app_rdm/communities_ui
dc397b7
to
e7bb9d9
Compare
731dfb8
to
3bbe812
Compare
jrcastro2
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peer reviewed with @carlinmack
LGTU!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: