-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement uv
as an optional python package management backend
#384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Explicitly makes the celery worker listen to the "default" and "low" queues.
* also, reword some help texts and clean up some strings
* implement `uv` as alternative for `pipenv` as python package management backend - to be configured in the file `.invenio` * handle the detection of the python package manager to be used and the generation of its commands in a central spot to lower the maintenance burden * make some commands (like translations) aware of the CLI config (and thus the configured python package manager) * implement commands for activating and removing the venv as shell scripts for `uv` as it doesn't implement such utilities
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
max-moser
commented
Feb 28, 2025
slint
approved these changes
Feb 28, 2025
* we got a warning that marks on fixtures don't have an effect
* the private config (`.invenio.private`) is not supposed to be added to version control and thus suited better for developer preferences than the public config (`.invenio`)
slint
reviewed
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slint
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Samk13
added a commit
to Samk13/invenio-dev-latest
that referenced
this pull request
Mar 1, 2025
* Update setup to include steps introduced in: inveniosoftware/invenio-cli#384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a variant of #383 with the
pnpm
/rspack
stuff stripped out, and some squashed commits.It only touches
uv
, since that's quite uncontroversial and works well enough already.How to set the Python package manager
If you have a
Pipfile
in your project, thenpipenv
will be used by default.If you have
pyproject.toml
and noPipfile
, thenuv
will be used by default.If your use case is not satisfied by this auto-magic, then you can explicitly configure the package manager to use in
.invenio
:Note the lack of quotes around the value
uv
.Currently, only
uv
andpipenv
are supported as values.