administration: integrate banners view module #15
Conversation
anikachurilova
force-pushed
the
integrate-invenio-administration-panel
branch
from
b6a5166 to
d248ea9
Compare
| "description": _( | ||
| "Message to be displayed on the banner. HTML format is supported." | ||
| ), | ||
| "rows": 10, |
There was a problem hiding this comment.
you might want to add to this PR the bump of the min version of react-invenio-forms in the webpack.py?
There was a problem hiding this comment.
It has to be done in invenio-administration PR inveniosoftware/invenio-administration#154
After the react-invenio-forms is released
* integrate admin banners list, edit, create and details view * disable expired banners after each create and update action * improve banners marshmallow schema * add http request data validation at create and update actions * improve banners macro * override banners list result to_dict() * move getting active banners to only db layer * cover macros with tests * closes inveniosoftware#10
anikachurilova
force-pushed
the
integrate-invenio-administration-panel
branch
from
d248ea9 to
03882d8
Compare
| def test_disable_expired_after_create_action(client, admin, headers): | ||
| """Disable expired banners after a create a banner action.""" | ||
| # create banner first | ||
| banner1 = BannerModel.create(banners["banner1"]) |
There was a problem hiding this comment.
I'm not sure about this but maybe as we are testing the resource we shouldn't use the model directly?
| def read_active_banners(self, identity, url_path): | ||
| """Retrieve the list of active banners with the given url_path.""" | ||
| self.require_permission(identity, "read") | ||
|
|
||
| active_banners = self.record_cls.get_active() | ||
|
|
||
| # filter by url_path | ||
| banners = [] | ||
| for banner in active_banners: | ||
| if banner.url_path is None or url_path.startswith(banner.url_path): | ||
| banners.append(banner) | ||
|
|
||
| return self.result_list( | ||
| self, | ||
| identity, | ||
| banners, | ||
| links_item_tpl=self.links_item_tpl, | ||
| ) |
There was a problem hiding this comment.
Just by curiosity. Why removing this function?
There was a problem hiding this comment.
Moved the filtering to the db layer, because it's easier to access from utils get_active_banners_for_request (I had some issues with accessing service methods from there).
Search view page (with pagination):
Details view:
Create banner view:
Create banner action:
Edit banner view:
Edit banner action:
Delete banner action:
Sort banners action:
By Url path
By Active
By Start Datetime
Search banners action:
Search by string field
Search by datetime field
Search by bool field
Loader preview:
Plain HTML into banner message:
