Implement alternative WebpackBundleProject for rspack
#176
Conversation
There was a problem hiding this comment.
sorted the devDependencies
| "@swc/helpers": "^0.5.11", | ||
| "sass-loader": "^16.0.0", | ||
| "swc-loader": "^0.2.6", | ||
|
|
There was a problem hiding this comment.
separated the rspack-specific deps with an empty line
There was a problem hiding this comment.
Further options for thinning-down this file:
- Since we depend on
@inveniosoftware/esling-config-invenio, we can probably remove all the dev dependencies that are already defined there - Because we're using
swc, all@babel/*packages can also probably go
| //preset: 'verbose', | ||
| // warnings: true, | ||
| // errors: true, | ||
| // errorsCount: true, | ||
| // errorStack: true, | ||
| // errorDetails: true, | ||
| // children: true, |
There was a problem hiding this comment.
some parts here could take some more cleanup
invenio_assets/assets/.npmrc
Outdated
There was a problem hiding this comment.
these options should only be picked up by pnpm; from my experience there was no negative effect on npm runs
invenio_assets/ext.py
Outdated
| @@ -59,7 +59,7 @@ def init_config(self, app): | |||
| ) | |||
|
|
|||
| # Flask-WebpackExt config | |||
| app.config.setdefault("WEBPACKEXT_PROJECT", "invenio_assets.webpack:project") | |||
| app.config.setdefault("WEBPACKEXT_PROJECT", "invenio_assets.webpack:webpack_project") | |||
There was a problem hiding this comment.
the original value is still provided for backwards compatibility, but moving forward i'd suggest going with the new fallback value
| "css-loader": "^6.0.0", | ||
| "css-minimizer-webpack-plugin": "^4.2.0", | ||
| "eslint-config-react-app": "^7.0.1", |
There was a problem hiding this comment.
this guy caused some issues with the pnpm + webpack build (but not for npm + webpack) due to some apparent conflicts in .eslintrc configs [1] – the simplest "fix" was to remove this dependency... not sure if that's the best way to go, but it did make the builds run through successfully
[1] unfortunately i don't have the error logs at hand anymore, but they should pop up again if this dep gets added back
max-moser
force-pushed
the
mm/rspack
branch
2 times, most recently
from
c103a5e to
5e2074f
Compare
* rspack provides a "--mode" flag which replaces "NODE_ENV" * rspack does not support the "--progress" flag
* "eslint-config-react-app" caused PNPM-based builds to complain about conflicting eslint configs
* duplicates from @inveniosoftware-eslint-config-invenio
* they still got installed even after removing them from the devDependencies here, so they are pulled in from somewhere else already * checked separately for the webpack and rspack builds
| @@ -162,7 +162,7 @@ var webpackConfig = { | |||
| }, | |||
| // Inline images smaller than 10k | |||
| { | |||
| test: /\.(png|jpe?g|gif|svg)(\?.*)?$/, | |||
| test: /\.(avif|webp|png|jpe?g|gif|svg)(\?.*)?$/, | |||
There was a problem hiding this comment.
added two new image file formats that we've been using at TUW for a while already, same for rspack
rspack-based build by setting the (already existing) configWEBPACKEXT_PROJECT = "invenio_assets.webpack:rspack_project"pnpmbuilds by setting the (new) configASSETS_NPM_PKG_CLS = "pynpm:PNPMPackage"Basically this PR provides adjusted versions of
package.jsonandwebpack.config.jsforrspack:rspack-package.jsonandrspack.config.js.The idea here is basically the rule of three, as popularized by Martin
FennerFowler.Right now we have two options (
webpackandrspack) – once we get more than that, we should actually start refactoring.