Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP build: migrate to Rspack #172

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

slint
Copy link
Member

@slint slint commented Sep 10, 2024

needs flask-webpackext PR
needs pywebpack PR

@utnapischtim
Copy link
Contributor

the commits d04b307, ab19770 and 6efde66 could be reverted. the main idea of those commits was to enable the possibility to give the app to the class directly to make it configurable which app is used.

since invenio-cli doesn't use that approach anymore those changes are not necessary anymore.

it could be helpful in the future to keep those changes, but for now they are not used anymore.

this would reduce the changes in this commit.

reverts with the same idea could be done in flask-webpackext too, described here: inveniosoftware/flask-webpackext#26 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants